cryptoe commented on code in PR #15382:
URL: https://github.com/apache/druid/pull/15382#discussion_r1395279702
##########
docs/api-reference/sql-api.md:
##########
@@ -390,12 +390,10 @@ Generally, the `sql` and `sql/statements` endpoints
support the same response bo
Keep the following in mind when submitting queries to the `sql/statements`
endpoint:
-- There are additional context parameters for `sql/statements`:
+- Apart from the context parameters mentioned
[here](../multi-stage-query/reference.md#context-parameters) there are
additional context parameters for `sql/statements` specifically:
- `executionMode` determines how query results are fetched. Druid
currently only supports `ASYNC`. You must manually retrieve your results after
the query completes.
- - `selectDestination` determines where final results get written. By
default, results are written to task reports. Set this parameter to
`durableStorage` to instruct Druid to write the results from SELECT queries to
durable storage, which allows you to fetch larger result sets. Note that this
requires you to have [durable storage for MSQ
enabled](../operations/durable-storage.md).
-
-- The only supported value for `resultFormat` is JSON LINES.
+ - `selectDestination` determines where final results get written. By
default, results are written to task reports. Set this parameter to
`durableStorage` to instruct Druid to write the results from SELECT queries to
durable storage, which allows you to fetch larger result sets. For result sets
with more than 3000 rows, it is highly recommended to use `durableStorage`.
Note that this requires you to have [durable storage for MSQ
enabled](../operations/durable-storage.md).
Review Comment:
The notion was using the same value we use for task report result chomping.
`Limits.MAX_SELECT_RESULT_ROWS` so that task reports donot ever explode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
