oo007 opened a new pull request, #15409: URL: https://github.com/apache/druid/pull/15409
Fixes https://github.com/apache/druid/issues/15380 ### Description Currently when we submit a task to druid and number of currently active tasks has already reached (`druid.indexer.queue.maxSize`) then 500 ISE is thrown as per shown in the screenshot in https://github.com/apache/druid/issues/15380. This fix will return `HTTP 429 Too Many Requests`(with proper error message) instead of 500 ISE, when we submit a task and queueSize has reached. Tested and attached the screenshot <img width="600" alt="Screenshot 2023-11-21 at 12 37 34 PM" src="https://github.com/apache/druid/assets/11345667/ad94736f-d3ef-4e61-bf67-8b00ae9a89a8";> #### Release note Returning correct Response Code HTTP 429 when taskQueue reached maxSize ##### Key changed/added classes in this PR * `TooManyTasksException` * `TaskQueue` * `OverlordResource` * `SeekableStreamSupervisor` * `TaskQueueTest` * `KinesisSupervisorTest` * `TaskLockConfigTest` * `SeekableStreamSupervisorStateTest` This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
