abhishekagarwal87 commented on code in PR #15409:
URL: https://github.com/apache/druid/pull/15409#discussion_r1400848780
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java:
##########
@@ -226,10 +227,11 @@ public Response taskPost(final Task task, @Context final
HttpServletRequest req)
taskQueue.add(task);
return Response.ok(ImmutableMap.of("task", task.getId())).build();
}
- catch (DruidException e) {
- return Response.status(e.getResponseCode())
- .entity(ImmutableMap.of("error", e.getMessage()))
- .build();
Review Comment:
You still need to retain this, unfortunately. The other DruidException could
be caught here as well. You can remove the other deprecated DruidException in a
follow-up clean up PR
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLockConfigTest.java:
##########
@@ -51,7 +52,7 @@ public void setup()
}
@Test
- public void testDefault() throws EntryExistsException
+ public void testDefault() throws EntryExistsException, DruidException
Review Comment:
these changes are not needed.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3954,6 +3954,10 @@ private void createTasksForGroup(int groupId, int
replicas)
stateManager.recordThrowableEvent(e);
log.error("Tried to add task [%s] but it already exists",
indexTask.getId());
}
+ catch (DruidException e) {
Review Comment:
lets not catch this exception here as we were not doing it before too.
##########
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTest.java:
##########
@@ -3735,7 +3736,7 @@ public void testGetCurrentTotalStats()
@Test
public void testDoNotKillCompatibleTasks()
- throws InterruptedException, EntryExistsException
+ throws InterruptedException, EntryExistsException, DruidException
Review Comment:
I am curious as to why you declared DruidException here. It's a runtime
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
