LakshSingla commented on code in PR #15354: URL: https://github.com/apache/druid/pull/15354#discussion_r1404268776
########## processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java: ########## @@ -48,6 +48,8 @@ public class GroupByQueryConfig private static final String CTX_KEY_BUFFER_GROUPER_INITIAL_BUCKETS = "bufferGrouperInitialBuckets"; private static final String CTX_KEY_BUFFER_GROUPER_MAX_LOAD_FACTOR = "bufferGrouperMaxLoadFactor"; private static final String CTX_KEY_MAX_ON_DISK_STORAGE = "maxOnDiskStorage"; + private static final String CTX_KEY_MAX_SELECTOR_DICTIONARY_SIZE = "maxSelectorDictionarySize"; + private static final String CTX_KEY_MAX_MERGING_DICTIONARY_SIZE = "maxMergingDictionarySize"; Review Comment: Kinda weird that [docs/configuration/index.md](https://github.com/apache/druid/blob/67c7b6248cfead7b9ab6950e13cc33583dbf8b88/docs/configuration/index.md?plain=1#L2164) says that we can override, even though overriding was a no-op. Looking up the blame, it is mentioned here https://github.com/apache/druid/pull/12763, that removing it was intentional. Perhaps we should not add it back then, and fix up the discrepancy above WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
