kgyrtkirk commented on code in PR #15354: URL: https://github.com/apache/druid/pull/15354#discussion_r1404279111
########## processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java: ########## @@ -48,6 +48,8 @@ public class GroupByQueryConfig private static final String CTX_KEY_BUFFER_GROUPER_INITIAL_BUCKETS = "bufferGrouperInitialBuckets"; private static final String CTX_KEY_BUFFER_GROUPER_MAX_LOAD_FACTOR = "bufferGrouperMaxLoadFactor"; private static final String CTX_KEY_MAX_ON_DISK_STORAGE = "maxOnDiskStorage"; + private static final String CTX_KEY_MAX_SELECTOR_DICTIONARY_SIZE = "maxSelectorDictionarySize"; + private static final String CTX_KEY_MAX_MERGING_DICTIONARY_SIZE = "maxMergingDictionarySize"; Review Comment: It was removed from the context as setting it might not be a common case + "complicates calculation" ...however as the tests also rely on similar ways...I went to add it back I believe its better to have all options follow the same convention... instead of doing something different just for these options...(which have silently caused that this feature become untested) fyi: @gianm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
