pranavbhole opened a new pull request, #15434:
URL: https://github.com/apache/druid/pull/15434

   
   ### Description
   In case of MVDs, we need to decide if need to aggregate multiple values or 
pick up first one from the list. This PR enables aggregateMultipleValues 
optional flag in all StringAnyAggregators. Also exposed the flag in ANY_VALUE 
sql function. 
   
   #### Fixed the bug ... 
   StringAnyVectorAggregator has some bug, in case of mvds, it always used to 
pick up first value, and it was inconsistent behavior with other StringAny 
Aggregator. aggregateMultipleValues is set to true by default. If user need 
first encountered values from mvd fields then aggregateMultipleValues can be 
set to false. 
   
   #### Release note
   Adding aggregateMultipleValues optional flag in ANY_VALUE and StringAny 
aggregators. 
   <hr>
   
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to