soumyava commented on code in PR #15434:
URL: https://github.com/apache/druid/pull/15434#discussion_r1407200355
##########
processing/src/test/java/org/apache/druid/query/aggregation/any/StringAnyBufferAggregatorTest.java:
##########
@@ -44,17 +51,14 @@ public void testBufferAggregate()
{
final String[] strings = {"AAAA", "BBBB", "CCCC", "DDDD", "EEEE"};
- Integer maxStringBytes = 1024;
+ int maxStringBytes = 1024;
Review Comment:
nit. final
##########
processing/src/test/java/org/apache/druid/query/aggregation/AggregatorFactoryTest.java:
##########
@@ -307,7 +307,7 @@ public void testWithName()
// string aggregators
new StringFirstAggregatorFactory("col", "col", null, 1024),
new StringLastAggregatorFactory("col", "col", null, 1024),
- new StringAnyAggregatorFactory("col", "col", 1024),
+ new StringAnyAggregatorFactory("col", "col", 1024, true),
Review Comment:
Just for sake of completeness can we add a test with false as the 3rd
paramter as well ?
##########
processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyBufferAggregator.java:
##########
@@ -34,11 +35,13 @@ public class StringAnyBufferAggregator implements
BufferAggregator
private final BaseObjectColumnValueSelector valueSelector;
private final int maxStringBytes;
+ final boolean aggregateMultipleValues;
Review Comment:
nit. private
##########
processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyVectorAggregator.java:
##########
@@ -43,11 +46,13 @@ public class StringAnyVectorAggregator implements
VectorAggregator
@Nullable
private final MultiValueDimensionVectorSelector multiValueSelector;
private final int maxStringBytes;
+ final boolean aggregateMultipleValues;
Review Comment:
nit. private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
