abhishekagarwal87 commented on code in PR #15449:
URL: https://github.com/apache/druid/pull/15449#discussion_r1408752462
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -65,7 +65,7 @@ public DefaultK8sApiClient(ApiClient realK8sClient, @Json
ObjectMapper jsonMappe
public void patchPod(String podName, String podNamespace, String
jsonPatchStr)
{
try {
- coreV1Api.patchNamespacedPod(podName, podNamespace, new
V1Patch(jsonPatchStr), "true", null, null, null);
+ coreV1Api.patchNamespacedPod(podName, podNamespace, new
V1Patch(jsonPatchStr), "true", null, null, null, false);
Review Comment:
what is this extra argument for?
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -114,7 +113,7 @@ public WatchResult watchPods(String namespace, String
labelSelector, String last
Watch.createWatch(
realK8sClient,
coreV1Api.listNamespacedPodCall(namespace, null, true, null,
null,
- labelSelector, null,
lastKnownResourceVersion, null, 0, true, null
+ labelSelector, null,
lastKnownResourceVersion, null, true, 0, true, null
Review Comment:
What is this extra argument for?
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -80,8 +80,7 @@ public DiscoveryDruidNodeList listPods(
)
{
try {
- V1PodList podList = coreV1Api.listNamespacedPod(podNamespace, null,
null, null, null, labelSelector, 0, null, null, null, null);
- Preconditions.checkState(podList != null, "WTH: NULL podList");
+ V1PodList podList = coreV1Api.listNamespacedPod(podNamespace, null,
null, null, null, labelSelector, 0, null, null, null, null, false);
Preconditions.checkState(podList != null, "WTH: NULL podList");
Review Comment:
same question about the extra boolean argument. Also line break is needed
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
