janjwerner-confluent commented on code in PR #15449:
URL: https://github.com/apache/druid/pull/15449#discussion_r1408764147
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -65,7 +65,7 @@ public DefaultK8sApiClient(ApiClient realK8sClient, @Json
ObjectMapper jsonMappe
public void patchPod(String podName, String podNamespace, String
jsonPatchStr)
{
try {
- coreV1Api.patchNamespacedPod(podName, podNamespace, new
V1Patch(jsonPatchStr), "true", null, null, null);
+ coreV1Api.patchNamespacedPod(podName, podNamespace, new
V1Patch(jsonPatchStr), "true", null, null, null, false);
Review Comment:
From:
https://javadoc.io/static/io.kubernetes/client-java-api/19.0.0/io/kubernetes/client/openapi/apis/CoreV1Api.html#patchNamespacedPod(java.lang.String,java.lang.String,io.kubernetes.client.custom.V1Patch,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.Boolean)
fieldValidation - fieldValidation instructs the server on how to handle
objects in the request (POST/PUT/PATCH) containing unknown or duplicate fields.
Valid values are: - Ignore: This will ignore any unknown fields that are
silently dropped from the object, and will ignore all but the last duplicate
field that the decoder encounters. This is the default behavior prior to v1.23.
- Warn: This will send a warning via the standard warning response header for
each unknown field that is dropped from the object, and for each duplicate
field that is encountered. The request will still succeed if there are no other
errors, and will only persist the last of any duplicate fields. This is the
default in v1.23+ - Strict: This will fail the request with a BadRequest error
if any unknown fields would be dropped from the object, or if any duplicate
fields are present. The error returned from the server will contain all unknown
and duplicate fields encountered. (optional)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
