TSFenwick commented on code in PR #15485:
URL: https://github.com/apache/druid/pull/15485#discussion_r1414539095
##########
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java:
##########
@@ -83,7 +87,8 @@ public KafkaEmitterConfig(
@Nullable @JsonProperty("request.topic") String requestTopic,
@Nullable @JsonProperty("segmentMetadata.topic") String
segmentMetadataTopic,
@JsonProperty("clusterName") String clusterName,
- @JsonProperty("producer.config") @Nullable Map<String, String>
kafkaProducerConfig
+ @JsonProperty("producer.config") @Nullable Map<String, String>
kafkaProducerConfig,
+ @JsonProperty("producer.secrets.config") @Nullable
DynamicConfigProvider<String> kafkaProducerSecrets
Review Comment:
property name could use some work imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
