abhishekrb19 commented on PR #15485: URL: https://github.com/apache/druid/pull/15485#issuecomment-1843742023
Thanks, @TSFenwick! Masking sensitive values makes sense to me. I think we can mask the sensitive keys/values directly in `druid.emitter.kafka.producer.config` instead of splitting up the config into secrets and non-secret configs. To do that, I think: - We can extend the masking logic in [`getMaskedCommand`](https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java#L696) to also account for parsing value strings, i.e., `splits[1]` (as with `sasl.jaas.config`). To keep it simple, we can consider only values of type `Map` for now. - Then, recurse through the values in the map to see if a property can be masked. This would more generally help mask any sensitive properties in the config. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
