kfaraz commented on code in PR #15480:
URL: https://github.com/apache/druid/pull/15480#discussion_r1420477998
##########
server/src/main/java/org/apache/druid/guice/SQLMetadataStorageDruidModule.java:
##########
@@ -130,21 +133,48 @@ public void configure(Binder binder)
.to(SQLMetadataStorageUpdaterJobHandler.class)
.in(LazySingleton.class);
- JsonConfigProvider.bind(binder, "druid.audit.manager",
SQLAuditManagerConfig.class);
-
- PolyBind.optionBinder(binder, Key.get(AuditManager.class))
- .addBinding(type)
- .to(SQLAuditManager.class)
- .in(LazySingleton.class);
-
- PolyBind.optionBinder(binder, Key.get(AuditManagerProvider.class))
- .addBinding(type)
- .to(SQLAuditManagerProvider.class)
- .in(LazySingleton.class);
-
PolyBind.optionBinder(binder, Key.get(MetadataSupervisorManager.class))
.addBinding(type)
.to(SQLMetadataSupervisorManager.class)
.in(LazySingleton.class);
}
+
+ private void configureAuditDestination(Binder binder)
+ {
+ PolyBind.createChoice(
+ binder,
+ "druid.audit.destination",
Review Comment:
Decided to use `druid.audit.manager.type` as it is easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
