kfaraz commented on code in PR #15480: URL: https://github.com/apache/druid/pull/15480#discussion_r1429015394
########## server/src/main/java/org/apache/druid/server/audit/AuditManagerConfig.java: ########## @@ -19,11 +19,20 @@ package org.apache.druid.server.audit; -import com.google.inject.Provider; -import org.apache.druid.audit.AuditManager; +import com.fasterxml.jackson.annotation.JsonSubTypes; +import com.fasterxml.jackson.annotation.JsonSubTypes.Type; +import com.fasterxml.jackson.annotation.JsonTypeInfo; -public interface AuditManagerProvider extends Provider<AuditManager> +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type", defaultImpl = SQLAuditManagerConfig.class) Review Comment: If we default to no-op, some existing functionality would misbehave: - change history dialogs in compaction config, load rules, etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
