georgew5656 opened a new pull request, #15527:
URL: https://github.com/apache/druid/pull/15527

   ### Description
   It is occasionally possible for a task running with the KubernetesTaskRunner 
to unsuccessfully push its status.json or for K8s to delete the log of the task 
before the overlord can pull it.
   
   This can happen if a pod is evicted due to memory or disk pressure. The 
thing to do in response to this is check K8s events/metrics but the error 
messages in druid are not very clear.
   
   Additionaly, when the overlord is unable to pull task logs, it uploads a 
empty log file which never gets deleted b/c the log file deleter ignores empty 
files.
   
   #### Fixed the bug ...
   #### Renamed the class ...
   #### Added a forbidden-apis entry ...
   
   - Update error taskStatus when status.json is not found.
   - Push a explanatory log if the task log is not found.
   
   #### Release note
   - Some QOL changes to mmless ingestion
   
   ##### Key changed/added classes in this PR
    * `KubernetesPeonLifecycle`
   
   
   This PR has:
   
   - [X] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [X] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [X] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to