suneet-s commented on code in PR #15527:
URL: https://github.com/apache/druid/pull/15527#discussion_r1422924053
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -329,6 +333,15 @@ protected void saveLogs()
FileUtils.copyInputStreamToFile(logWatch.getOutput(), file.toFile());
} else {
log.debug("Log stream not found for %s", taskId.getOriginalTaskId());
+ FileUtils.writeStringToFile(
+ file.toFile(),
+ StringUtils.format(
+ "Peon for task [%s] did not report any logs. Check k8s
metrics and events for the pod to see what happened.",
Review Comment:
Should the log line on 335 be updated to include this information. Also is
there a reason that log message isnot warn?
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -288,7 +288,11 @@ private TaskStatus getTaskStatus(long duration)
TaskStatus.class
);
} else {
- taskStatus = TaskStatus.failure(taskId.getOriginalTaskId(), "task
status not found");
+ log.info(
Review Comment:
```suggestion
log.warn(
```
Why info and not warn? This seems like it's not normal operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
