LakshSingla commented on PR #14462: URL: https://github.com/apache/druid/pull/14462#issuecomment-1849757761
Thanks for the patch @ankit0811. I think there's some follow up that can be done, in this area 1. Make sure string pairs work as expected with null & empty strings - This has been a regression before the patch, and I have raised a PR for the same 2. Make the EARLIEST and the LATEST work with SQL 3. Add tests for MSQ 4. Look for some cleaner abstractions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
