ankit0811 commented on code in PR #14462:
URL: https://github.com/apache/druid/pull/14462#discussion_r1423429737
##########
processing/src/test/java/org/apache/druid/query/aggregation/first/DoubleFirstVectorAggregationTest.java:
##########
@@ -86,39 +91,80 @@ public long[] getLongVector()
@Override
public boolean[] getNullVector()
{
- return NULLS;
+ return null;
}
};
- selector = new BaseDoubleVectorValueSelector(new
NoFilterVectorOffset(VALUES.length, 0, VALUES.length)
+ selector = new VectorObjectSelector()
Review Comment:
Yes. It will be required as the selector can now be of either VectorObject
or VectorValue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
