clintropolis opened a new pull request, #15543:
URL: https://github.com/apache/druid/pull/15543
### Description
Fixes an issue which can occur when using `ExpressionPostAggregator` on on
array types output from grouping engine in certain situations such as inline
data. The grouping engine uses wrapper types for arrays,
`ComparableStringArray` and `ComparableList` so that they implement
`Comparable` (current requirement for all grouping dimension types). The native
expression system did not recognize these types, leading to them being treated
as `COMPLEX` rather than `ARRAY` types, which made stuff sad.
This also made an adjustment to `FunctionalExpr` which after #14987 was
causing things like cast exceptions to eventually end up going through
`DruidException.defensive` and presented as unknown server-side errors. While
in this case the class cast exception really was a bug, in most cases it would
not be, and so these are now handled as user errors so that the exception
message is now shown to the user.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
