soumyava commented on code in PR #15552:
URL: https://github.com/apache/druid/pull/15552#discussion_r1425729866


##########
processing/src/main/java/org/apache/druid/math/expr/ConstantExpr.java:
##########
@@ -464,15 +473,18 @@ public String toString()
 
 class ComplexExpr extends ConstantExpr<Object>
 {
+  final ExprEval expr;

Review Comment:
   Curious since we are evaluating this early, does the equals and hash method 
need to honor this ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to