kgyrtkirk commented on PR #15552:
URL: https://github.com/apache/druid/pull/15552#issuecomment-1855169062
I wanted to remove the `isPrimitive` check; but then put it back - as I
think the following test should pass:
```
final ExprEval<?> complexEval =
ExprEval.ofComplex(ExpressionType.UNKNOWN_COMPLEX, new Object());
final ExprEval<?> complexEval2 = ExprEval.ofComplex(new
ExpressionType(ExprType.COMPLEX, null, null), new Object());
Assert.assertEquals(
ExpressionTypeConversion.autoDetect(complexEval, complexEval),
ExpressionTypeConversion.autoDetect(complexEval2, complexEval)
);
```
`DOUBLE` is bad enough that if it starts returning that for `COMPLEX` it
will be painfull enough to fix it...having at least consistent behaviuor will
help to fix it correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
