abhishekrb19 commented on code in PR #15495:
URL: https://github.com/apache/druid/pull/15495#discussion_r1425939246
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -957,7 +961,8 @@ private List<SegmentIdWithShardSpec>
generateSegmentIdsWithShardSpecs(
final RowSignature signature,
final ClusterBy clusterBy,
final ClusterByPartitions partitionBoundaries,
- final boolean mayHaveMultiValuedClusterByFields
+ final boolean mayHaveMultiValuedClusterByFields,
+ final Boolean isStageOutputEmpty
) throws IOException
{
if (destination.isReplaceTimeChunks()) {
Review Comment:
Yeah, I feel delegating what to do with an empty stage output should be the
responsibility of the appropriate query type. In this case, both happen to
return early, but I think as the MSQ engine evolves and/or we want different
behavior, it'd be better to have that determination in these delegating
functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
