abhishekrb19 commented on code in PR #15495:
URL: https://github.com/apache/druid/pull/15495#discussion_r1439721237
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1268,6 +1296,10 @@ private Int2ObjectMap<List<SegmentIdWithShardSpec>>
makeSegmentGeneratorWorkerFa
{
final Int2ObjectMap<List<SegmentIdWithShardSpec>> retVal = new
Int2ObjectAVLTreeMap<>();
+ if (segmentsToGenerate.isEmpty()) {
Review Comment:
We could, although it'll be unreachable given we validate this scenario and
throw an exception before the segments are generated. So code coverage will
complain without tests for the unreachable branch, so I can add a comment that
things are already validated before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
