somu-imply commented on code in PR #15470:
URL: https://github.com/apache/druid/pull/15470#discussion_r1427163081
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/LazilyDecoratedRowsAndColumns.java:
##########
@@ -418,4 +418,116 @@ private Pair<byte[], RowSignature>
naiveMaterialize(RowsAndColumns rac)
return Pair.of(frameWriter.toByteArray(), sigBob.build());
}
+
+
+ @Nullable
+ public Pair<byte[], RowSignature> naiveMaterializeToRowFrames(RowsAndColumns
rac)
Review Comment:
Try to have a separate semantic interface like the WireTransferable. Let's
call it FrameSerializable. Give it methods such a makeColumnFrame() and
makeRowFrame(). Create a default implementation and then in operators.go ask
using the as method to get the type of frame I want (row based or columnar).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
