somu-imply commented on code in PR #15470:
URL: https://github.com/apache/druid/pull/15470#discussion_r1460302335
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2728,8 +2731,21 @@ private void startStages() throws IOException,
InterruptedException
throw new MSQException(new
InsertCannotBeEmptyFault(task.getDataSource()));
}
- final ClusterByPartitions partitionBoundaries =
- queryKernel.getResultPartitionBoundariesForStage(shuffleStageId);
+ // Q for MSQ folks
Review Comment:
There was an earlier comment up top that this might need rework. I want to
understand a bit more and have put a comment in code. This gets all my new
tests + existing tests to pass, so I have kept it here but need to understand
in more detail and need clarification from MSQ folks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
