clintropolis opened a new pull request, #15585:
URL: https://github.com/apache/druid/pull/15585

   ### Description
   WIP
   
   ```
   SELECT string4, COUNT(*) FROM foo WHERE REGEXP_EXTRACT(string1, '^1') IS NOT 
NULL OR REGEXP_EXTRACT('Z' || string2, '^Z2') IS NOT NULL GROUP BY 1
   ```
   
   before:
   ```
   Benchmark                        (query)  (rowsPerSegment)  (schema)  
(vectorize)  Mode  Cnt    Score    Error  Units
   SqlExpressionBenchmark.querySql       40           5000000  explicit        
false  avgt    5  279.224 ±  3.353  ms/op
   SqlExpressionBenchmark.querySql       40           5000000      auto        
false  avgt    5  274.911 ±  5.642  ms/op
   ```
   
   after:
   ```
   Benchmark                        (query)  (rowsPerSegment)  (schema)  
(vectorize)  Mode  Cnt    Score   Error  Units
   SqlExpressionBenchmark.querySql       40           5000000  explicit        
false  avgt    5  194.301 ± 4.236  ms/op
   SqlExpressionBenchmark.querySql       40           5000000      auto        
false  avgt    5  187.447 ± 3.748  ms/op
   ```
   <hr>
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to