clintropolis commented on PR #15585: URL: https://github.com/apache/druid/pull/15585#issuecomment-1865302129
One thing I'm still thinking about is how to use the same strategy of #13977 and #15551 which allow automatically skipping using indexes if the cardinality of the underlying column is "too high" compared to the total number of rows to be scanned. The main problem is I haven't decided on the best way to expose the underlying `ColumnConfig` that controls these settings to the `VirtualColumn` index supplier method. I think its probably best to either make it available to `ColumnSelectorColumnIndexSelector` to pass in to the virtual columns, or available through any `ColumnSelector` which is already passed into the virtual columns. Still thinking about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
