mustajibmk commented on code in PR #15408:
URL: https://github.com/apache/druid/pull/15408#discussion_r1430136073
##########
extensions-core/lookups-cached-global/src/test/java/org/apache/druid/query/lookup/namespace/JdbcExtractionNamespaceUrlCheckTest.java:
##########
@@ -159,46 +159,6 @@ public boolean isEnforceAllowedProperties()
}
);
}
-
- @Test
- public void testWhenInvalidUrlFormat()
Review Comment:
The parser no longer checks if every component is in the expected format it
only checks if the URL starts with one of the required schema i.e
`jdbc:mysql`,`jdbc:mysql:loadbalancer`, etc. So we will not be able to
determine if this is a valid/invalid URL just by using the parser.
The way to determine if the URL is valid is by creating a connection with
the DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
