findingrish commented on code in PR #15475:
URL: https://github.com/apache/druid/pull/15475#discussion_r1440220573
##########
server/src/main/java/org/apache/druid/client/CoordinatorServerView.java:
##########
@@ -114,6 +115,13 @@ public ServerView.CallbackAction segmentViewInitialized()
runTimelineCallbacks(TimelineCallback::timelineInitialized);
return ServerView.CallbackAction.CONTINUE;
}
+
+ @Override
+ public ServerView.CallbackAction
segmentSchemasAnnounced(SegmentSchemas segmentSchemas)
+ {
+ runTimelineCallbacks(callback ->
callback.segmentSchemasAnnounced(segmentSchemas));
Review Comment:
> Why are listeners of the timeline waiting for an event which does not
touch the timeline at all.
CoordinatorServerView is simply delegating schema update events to listeners
registered on the timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
