clintropolis opened a new pull request, #15629:
URL: https://github.com/apache/druid/pull/15629
### Description
fixes some bugs caused by some limitations of the original design of how
DruidPredicateFactory interacts with 3-value logic. The primary impacted area
was with how filters on values transformed with expressions or extractionFn
which turn non-null values into nulls, which were not possible to be modelled
with the 'isNullInputUnknown' method
changes:
* adds DruidObjectPredicate to specialize string, array, and object based
predicates instead of using guava Predicate
* DruidPredicateFactory now uses DruidObjectPredicate
* introduces DruidPredicateMatch enum, which all predicates returned from
DruidPredicateFactory now use instead of booleans to indicate match. This means
DruidLongPredicate, DruidFloatPredicate, DruidDoublePredicate, and the newly
added DruidObjectPredicate apply methods all now return DruidPredicateMatch.
This allows matchers and indexes
* isNullInputUnknown has been removed from DruidPredicateFactory
#### Release note
_tbd_
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
