clintropolis commented on code in PR #15629:
URL: https://github.com/apache/druid/pull/15629#discussion_r1443292306
##########
processing/src/main/java/org/apache/druid/query/filter/InDimFilter.java:
##########
@@ -302,10 +304,14 @@ public BitmapColumnIndex
getBitmapColumnIndex(ColumnIndexSelector selector)
if (indexSupplier == null) {
// column doesn't exist, match against null
- return Filters.makeMissingColumnNullIndex(
- predicateFactory.makeStringPredicate().apply(null),
- selector
- );
+ DruidPredicateMatch match =
predicateFactory.makeStringPredicate().apply(null);
Review Comment:
heh i did that at first but were only the 3 callers so seemed barely worth
having, then again after sleeping on it i agree, it is just enough callers so
will add it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
