Pankaj260100 commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1445979916
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +148,38 @@ public SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other, Comparator<SequenceOffsetType> comparator)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ boolean res = false;
+ for (Map.Entry<PartitionIdType, SequenceOffsetType> entry :
partitionSequenceNumberMap.entrySet()) {
+ PartitionIdType partitionId = entry.getKey();
+ SequenceOffsetType sequenceOffset = entry.getValue();
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null &&
comparator.compare(sequenceOffset,
otherStart.partitionSequenceNumberMap.get(partitionId)) > 0) {
Review Comment:
It will be true for both. For First the metadata from DB is null and it
checks for validStart(). And for the second it will try to match old and new
metadata, using a+b equals b+a. So, it will also be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
