abhishekagarwal87 commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1375420281
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +149,37 @@ public SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other, Comparator<SequenceOffsetType> comparator)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& comparator.compare(sequenceOffset,
otherStart.partitionSequenceNumberMap.get(partitionId)) > 0) {
+ res.set(true);
+ }
+ }
+ );
Review Comment:
Nit - You don't need AtomicReference here. could use a simple for each loop
for map.entryset
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaDataSourceMetadata.java:
##########
@@ -58,4 +60,17 @@ protected
SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long> createConc
{
return new KafkaDataSourceMetadata(seekableStreamSequenceNumbers);
}
+
+ @Override
+ public int compareTo(KafkaDataSourceMetadata other)
Review Comment:
Please add some comments as to how this method is to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
