cryptoe commented on code in PR #15525:
URL: https://github.com/apache/druid/pull/15525#discussion_r1446241978
##########
processing/src/main/java/org/apache/druid/query/aggregation/SerializablePairLongStringSimpleStagedSerde.java:
##########
@@ -88,6 +102,8 @@ public SerializablePairLongString deserialize(ByteBuffer
byteBuffer)
readOnlyBuffer.get(stringBytes, 0, stringSize);
lastString = StringUtils.fromUtf8(stringBytes);
+ } else if (stringSize < 0) {
Review Comment:
Shoudn't this be
If stringSize==0 then return null
stringSize==-1 then return ""
else
strValue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
