clintropolis commented on code in PR #15525: URL: https://github.com/apache/druid/pull/15525#discussion_r1446692701
########## processing/src/main/java/org/apache/druid/query/aggregation/SerializablePairLongStringDeltaEncodedStagedSerde.java: ########## @@ -36,6 +36,14 @@ * * otherwise * Long:Integer:bytes + * + * The StringSize can be following: + * -1 : Denotes an empty string + * 0 : Denotes a null string Review Comment: this is really sad that null and empty have to be flipped like this... its almost sad enough to consider bumping the entire column version, but I don't think this needs done for now, and that would be more disruptive since old versions wouldn't be able to read the new version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
