This is an automated email from the ASF dual-hosted git repository.
karan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 0b91cc4db20 Fix incorrect tests in Sting first/last serde's null
handling (#15657)
0b91cc4db20 is described below
commit 0b91cc4db20bb2395eb7177d9e15d04353c885c8
Author: Laksh Singla <[email protected]>
AuthorDate: Wed Jan 10 19:16:12 2024 +0530
Fix incorrect tests in Sting first/last serde's null handling (#15657)
Fixes a couple of incorrect test cases, that got merged accidentally
---
...wardCompatibleSerializablePairLongStringSimpleStagedSerdeTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/processing/src/test/java/org/apache/druid/query/aggregation/BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest.java
b/processing/src/test/java/org/apache/druid/query/aggregation/BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest.java
index db5e5490f65..effa47b471f 100644
---
a/processing/src/test/java/org/apache/druid/query/aggregation/BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest.java
+++
b/processing/src/test/java/org/apache/druid/query/aggregation/BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest.java
@@ -59,7 +59,7 @@ public class
BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest
SerializablePairLongString value = new
SerializablePairLongString(Long.MAX_VALUE, null);
// Write using the older serde, read using the newer serde
Assert.assertEquals(
- new SerializablePairLongString(Long.MAX_VALUE, ""),
+ new SerializablePairLongString(Long.MAX_VALUE, null),
readUsingSerde(writeUsingSerde(value, OLDER_SERDE), SERDE)
);
// Write using the newer serde, read using the older serde
@@ -77,7 +77,7 @@ public class
BackwardCompatibleSerializablePairLongStringSimpleStagedSerdeTest
SerializablePairLongString value = new
SerializablePairLongString(Long.MAX_VALUE, "");
// Write using the older serde, read using the newer serde
Assert.assertEquals(
- new SerializablePairLongString(Long.MAX_VALUE, ""),
+ new SerializablePairLongString(Long.MAX_VALUE, null),
readUsingSerde(writeUsingSerde(value, OLDER_SERDE), SERDE)
);
// Write using the newer serde, read using the older serde
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
