kgyrtkirk opened a new pull request, #15668:
URL: https://github.com/apache/druid/pull/15668
this patch changes the `WindowFrame` internals / representation a bit;
introduces a dedicated frametype for `rows`, `groups`, `unbounded` - so that
later if we decide to add better ranges support it will less likely need a
bigger refactor
it also changes how its represented in the native query:
```diff
- frame: { peerType: "ROWS", lowUnbounded: true, lowOffset: 0,
uppUnbounded: true, uppOffset: 0 }
+ frame: { type: unbounded }
```
```diff
- frame: { peerType: "ROWS", lowUnbounded: false, lowOffset: 0,
uppUnbounded: false, uppOffset: 2 }
+ frame: { type: rows, lowerOffset: 0, upperOffset: 2 }
```
```diff
- frame: { peerType: "RANGE", lowUnbounded: true, lowOffset: 0,
uppUnbounded: false, uppOffset: 0, orderBy: [{ column: l1, direction: ASC }] }
+ frame: { type: group, upperOffset: 0, orderBy: [{ column: l1,
direction: ASC }] }
```
right now the current patch has some unrelated changes as its built on top
of: #15365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
