zachjsh commented on code in PR #15630: URL: https://github.com/apache/druid/pull/15630#discussion_r1454128284
########## extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorageDruidModule.java: ########## @@ -137,9 +135,10 @@ public AzureClientFactory getAzureClientFactory(final AzureAccountConfig config) @Provides @LazySingleton Review Comment: This seems to be providing the storage used for the segments in particular, is that right? Given this should be maybe provide this with an annotation, so that other existing / future consumers of the AzureStorage that have the AzureStorage instance injected are clear in their intention to use the segment storage location rather than ingest location? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
