clintropolis commented on code in PR #15687:
URL: https://github.com/apache/druid/pull/15687#discussion_r1454343475
##########
processing/src/main/java/org/apache/druid/segment/serde/NestedCommonFormatColumnPartSerde.java:
##########
@@ -308,6 +308,10 @@ public void read(ByteBuffer buffer, ColumnBuilder builder,
ColumnConfig columnCo
ColumnType logicalType = simpleType == null ? ColumnType.NESTED_DATA :
simpleType;
builder.setType(logicalType);
builder.setNestedCommonFormatColumnSupplier(supplier);
+ // nested columns only have a null value index
+ if (hasNulls) {
+ builder.setIndexSupplier(supplier, false, false);
+ }
Review Comment:
yea, we've talked about doing this in the past, i agree it would be nicer to
move it to the same place we get selectors from, but we need to re-arrange some
other stuff to make this stuff closable and ensure it gets closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
