AmatyaAvadhanula commented on code in PR #15637:
URL: https://github.com/apache/druid/pull/15637#discussion_r1454620550
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -443,4 +443,10 @@ SegmentPublishResult commitMetadataOnly(
* @return DataSegment used segment corresponding to given id
*/
DataSegment retrieveSegmentForId(String id, boolean includeUnused);
+
+ /**
+ * Clean entries in upgrade segments table after the corresponding replace
task has ended
+ * @param taskId - task id with the replace locks
+ */
+ void cleanUpgradeSegmentsTableForTask(String taskId);
Review Comment:
Done
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2267,7 +2267,8 @@ private String buildSqlToInsertSegments()
*
* @return Map from append Segment ID to REPLACE lock version
*/
- private Map<String, String> getAppendSegmentsCommittedDuringTask(
+ @VisibleForTesting
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
