kfaraz commented on code in PR #15637:
URL: https://github.com/apache/druid/pull/15637#discussion_r1455498460
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -1220,6 +1220,14 @@ public void remove(final Task task)
try {
try {
log.info("Removing task[%s] from activeTasks", task.getId());
+ if (findLocksForTask(task).stream().anyMatch(lock -> lock.getType() ==
TaskLockType.REPLACE)) {
Review Comment:
Should we use `findReplaceLocksForTask` method instead? But it would return
only non-revoked locks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
