kfaraz commented on code in PR #15729: URL: https://github.com/apache/druid/pull/15729#discussion_r1460169168
########## docs/configuration/index.md: ########## @@ -378,7 +378,7 @@ You can configure Druid services to emit [metrics](../operations/metrics.md) reg |Property|Description|Default| |--------|-----------|-------| |`druid.monitoring.emissionPeriod`| Frequency that Druid emits metrics.|`PT1M`| -|[`druid.monitoring.monitors`](#metrics-monitors)|Sets list of Druid monitors used by a service.|none (no monitors)| +|[`druid.monitoring.monitors`](#metrics-monitors)|Sets list of Druid monitors used by a service.<br /><br />Because individual monitors sometimes only work on specific process types, it is best to set this property for each process type individually in e.g. `historical/runtime.properties` rather than `_common/common.runtime.properties`.|none (no monitors)| Review Comment: Since we are touching this anyway, I think it's better to have the link on the text `Druid monitors` rather than the config path. Same point for the next config `druid.emitter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
