xvrl commented on code in PR #15753:
URL: https://github.com/apache/druid/pull/15753#discussion_r1465163770
##########
extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java:
##########
@@ -48,7 +52,29 @@ public class Pac4jFilter implements Filter
{
private static final Logger LOGGER = new Logger(Pac4jFilter.class);
- private static final HttpActionAdapter<String, JEEContext>
NOOP_HTTP_ACTION_ADAPTER = (HttpAction code, JEEContext ctx) -> null;
+ private static final HttpActionAdapter<String, JEEContext>
HTTP_ACTION_ADAPTER = (HttpAction action, JEEContext context) -> {
Review Comment:
nit, a more explicit name to clarify what kind of http action adapter this
is and what it does would be nice. NOOP was pretty clear before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
