AmatyaAvadhanula opened a new pull request, #15813:
URL: https://github.com/apache/druid/pull/15813
This PR fixes 2 issues with Streaming ingestion with concurrent replace.
1) Temporary duplicate results in queries
Suppose a streaming ingestion task has open segments V0-1 with a used
segment V0-0, and a replace occurs concurrently with version V1. The replace
job would convert the used segment to V1-0, and the open pending segment to
V1-1.
However, when the appending job commits segments using the transactional
insert action, the pending segment is committed as V1-2. This means that there
could be a period where V1-1 has not been unannounced and V1-2 has been loaded,
during which both results are visible.
This PR aims to remove that redundancy by committing V1-1 directly.
2) Temporary data loss in queries
Currently, handoff for streaming ingestion looks only at the original set of
segments to the append action. This PR enhances the notifier to look at the
upgraded segments as well. Without this change, an append that happens after a
replace may miss data that relies on the handoff.
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
