TestBoost commented on PR #15533: URL: https://github.com/apache/druid/pull/15533#issuecomment-1925146292
Sorry for the late reply and I just came back from holiday. I tried to make the changes as you said. However, I found there is another test `testRetrieveUnusedSegmentsActionWithNowUsedLastUpdatedTime` in this test class which also needs `expectedUnusedSegments`. We need to create `expectedUsedSegments` in the method `testRetrieveUsedSegmentsAction` and create `expectedUnusedSegments` in the method `testRetrieveUnusedSegmentsAction` and `testRetrieveUnusedSegmentsActionWithNowUsedLastUpdatedTime`. This makes the test even slower than the original one. The original test takes `3.583 s`. After applying this commit, it takes `2.939 s`. And after making `expectedUsedSegments` and `expectedUnusedSegments` as local variables, it takes `4.761 s`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
