zachjsh commented on code in PR #15836: URL: https://github.com/apache/druid/pull/15836#discussion_r1480473099
########## sql/src/main/java/org/apache/druid/sql/calcite/parser/DruidSqlInsert.java: ########## @@ -41,27 +41,40 @@ public class DruidSqlInsert extends DruidSqlIngest // This allows reusing super.unparse public static final SqlOperator OPERATOR = SqlInsert.OPERATOR; - /** - * While partitionedBy and partitionedByStringForUnparse can be null as arguments to the constructor, this is - * disallowed (semantically) and the constructor performs checks to ensure that. This helps in producing friendly - * errors when the PARTITIONED BY custom clause is not present, and keeps its error separate from JavaCC/Calcite's - * custom errors which can be cryptic when someone accidentally forgets to explicitly specify the PARTITIONED BY clause - */ public DruidSqlInsert( Review Comment: made static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
