zachjsh commented on code in PR #15836:
URL: https://github.com/apache/druid/pull/15836#discussion_r1481922636


##########
sql/src/test/java/org/apache/druid/sql/calcite/parser/DruidSqlUnparseTest.java:
##########
@@ -41,7 +41,7 @@ public void testUnparseInsert() throws ParseException
     String sqlQuery = "INSERT INTO dst SELECT * FROM foo PARTITIONED BY ALL 
TIME";
     String prettySqlQuery = "INSERT INTO \"dst\"\n"
                      + "SELECT *\n"
-                     + "    FROM \"foo\" PARTITIONED BY ALL TIME";
+                     + "    FROM \"foo\" PARTITIONED BY ALL";

Review Comment:
   effectively the same. When the query is unparsed and rewritten, it writes 
the sqlNode for partitionedBy as a Granularity, which only has en eum for the 
equivalent effective granularity, `ALL`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to