BartMiki commented on PR #15754: URL: https://github.com/apache/druid/pull/15754#issuecomment-1931701123
@abhishekagarwal87 One more question regarding the test. So the result is that: ``` Warning: Flakes: Warning: org.apache.druid.discovery.BrokerClientTest.testError Error: Run 1: BrokerClientTest.testError:121 » Druid Request to broker failed due to failed response status: [504 ] Error: Run 2: BrokerClientTest.testError:121 » Druid Request to broker failed due to failed response status: [504 ] Error: Run 3: BrokerClientTest.testError:121 » Druid Request to broker failed due to failed response status: [504 ] [INFO] Run 4: PASS ``` so the test actually passes, but it is flaky. So it works, but it does not use the RetryUtils here. The actual failure was this line coverage. So I wonder if I should fix this test to rely on RetryUtils or just leave it as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
