BartMiki commented on PR #15754: URL: https://github.com/apache/druid/pull/15754#issuecomment-1928069100
So should I fix this test? Also, the code coverage for the TimeoutException is a bit tricky as it is so nested that it is hard to test. I'm thinking about refactoring this logic into a separate class that is easier to test. That would also improve the readability of the existing code. What do you think @abhishekagarwal87 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
