cryptoe commented on code in PR #15689: URL: https://github.com/apache/druid/pull/15689#discussion_r1481342610
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/ExportMSQDestination.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.indexing.destination; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.msq.querykit.ShuffleSpecFactories; +import org.apache.druid.msq.querykit.ShuffleSpecFactory; +import org.apache.druid.server.security.Resource; +import org.apache.druid.server.security.ResourceType; +import org.apache.druid.sql.http.ResultFormat; +import org.apache.druid.storage.ExportStorageProvider; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.util.List; +import java.util.Objects; +import java.util.Optional; + +/** + * Destination used by tasks that write the results as files to an external destination. {@link #resultFormat} denotes + * the format of the file created and {@link #exportStorageProvider} denotes the type of external + * destination. + * <br> + * {@link #replaceTimeChunks} denotes how existing files should be handled. + * - If the value is null, the results are appended to the existing files. + * - If the value is present, existing files will be deleted according to time intervals. + */ +public class ExportMSQDestination implements MSQDestination +{ + public static final String TYPE = "export"; + private final ExportStorageProvider exportStorageProvider; + private final ResultFormat resultFormat; Review Comment: We can change it later. Only thing we have to be take into account is the json key:value the taskQuery Maker sends for CSV should remain unchanged to support backward compatibility during upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
