adarshsanjeev commented on code in PR #15689:
URL: https://github.com/apache/druid/pull/15689#discussion_r1481440460
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1772,16 +1777,10 @@ private static QueryDefinition makeQueryDefinition(
} else {
queryToPlan = querySpec.getQuery();
}
- } else if (querySpec.getDestination() instanceof TaskReportMSQDestination)
{
- shuffleSpecFactory = ShuffleSpecFactories.singlePartition();
- queryToPlan = querySpec.getQuery();
- } else if (querySpec.getDestination() instanceof
DurableStorageMSQDestination) {
- shuffleSpecFactory = ShuffleSpecFactories.getGlobalSortWithTargetSize(
- MultiStageQueryContext.getRowsPerPage(querySpec.getQuery().context())
- );
- queryToPlan = querySpec.getQuery();
} else {
- throw new ISE("Unsupported destination [%s]",
querySpec.getDestination());
+ shuffleSpecFactory = querySpec.getDestination()
+
.getShuffleSpecFactory(MultiStageQueryContext.getRowsPerPage(querySpec.getQuery().context()));
Review Comment:
Do you mean a comment every where the function is being called? We don't
pass the whole context to getShuffleSpecFactory(), just the integer, so would
this need to be specifically mentioned somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
